Allow overriding connection while executing the sql magic.#1
Merged
Allow overriding connection while executing the sql magic.#1
connection while executing the sql magic.#1Conversation
srinathnarayanan
approved these changes
Dec 10, 2024
Collaborator
|
I'm not clear how this will have any effect in our notebook container since we are installing the official Jupysql package there. |
Author
|
@kesmit13 We will update the notebook image to install this fork instead of installing from pypi. We have done the same for modifications to dash library: Dockerfile changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Allow overriding
connectionwhile executing the sql magic. This is used in singlestore-labs/singlestoredb-python#47.Issue number
Checklist before requesting a review
pkgmt format